search

ory / fosite-example

Apache License 2.0
78 stars 34 forks source link

Update for compose API changes #17

Closed pmundt closed 4 years ago

pmundt commented 4 years ago

The upstream fosite compose API underwent a number of changes which were not reflected here:

authorizationserver/oauth2.go:35:45: not enough arguments in call to compose.NewOAuth2HMACStrategy have (compose.Config, []byte) want (compose.Config, []byte, [][]byte) authorizationserver/oauth2.go:38:62: not enough arguments in call to compose.NewOpenIDConnectStrategy have (rsa.PrivateKey) want (compose.Config, *rsa.PrivateKey)

Update accordingly - closes #16

Signed-off-by: Paul Mundt paul.mundt@adaptant.io

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

aeneasr commented 4 years ago

Thank you, this looks good! You also need to update the dependencies to the latest fosite version for the CI to pass, and for the example to work when people use Go Modules.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at ?% when pulling 5c90d399152764ae96f7ec5dccb1e77a24220ee3 on adaptant-labs:compose-api-fixes into 704b4fefce417605351473052bb12ed588fdccec on ory:master.

pmundt commented 4 years ago

@aeneasr this is now done - I've done the go mod conversion and updated the travis script accordingly.

aeneasr commented 4 years ago

Awesome, thanks!