Consider upgrading to go.opentelemetry.io/otel/trace@1.27.0

zzzzzztt commented 5 months ago

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[ ] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Ory Network Project

No response

Describe your problem

The go.opentelemetry.io/otel/trace version is conflict to the one used by go.opentelemetry.io/contrib, 'module go.opentelemetry.io/otel/exporters/otlp/otlptrace found (v1.27.0), but does not contain package go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal' could we update to latest version

Describe your ideal solution

update verion to v1.27.0

Workarounds or alternatives

update verion to v1.27.0

Version

v1.46.1

Additional Context

No response

pontello commented 5 months ago

+1 for this upgrade. I am looking forward to using fosite but my project has a third-party dependency on otel v1.27.0 then I get this error.

go get github.com/ory/fosite
go: github.com/ory/fosite imports
    github.com/ory/x/otelx imports
    go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp imports
    go.opentelemetry.io/otel/exporters/otlp/internal: cannot find module providing package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/ory/fosite imports
    github.com/ory/x/otelx imports
    go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp imports
    go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal: cannot find module providing package go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal
go: github.com/ory/fosite imports
    github.com/ory/x/otelx imports
    go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp imports
    go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig: cannot find module providing package go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfi

jensmcatanho commented 5 months ago

+1 for this as well. I have the same problem mentioned by @pontello. On a related note, the current version indirectly imports version v0.42.0 from otelhttp which has a reported memory exhaustion vulnerability fixed in v0.44.0.

vivshankar commented 2 months ago

Opened the linked PR (https://github.com/ory/x/pull/808) to bump up the version. It appears that will need to go in before Fosite can be updated.

ory / fosite