ory / hydra-client-java

Apache License 2.0
26 stars 7 forks source link

document (and generate) the "scope" parameter in token endpoint #2

Closed stefanorg closed 2 years ago

stefanorg commented 4 years ago

Hi @aeneasr, in the token endpoint documentation (https://www.ory.sh/hydra/docs/reference/api#the-oauth-20-token-endpoint) the optional scope parameter is missing and therefore when generating the client with the operapi generator, there is no way to pass a scope in a client_credentials grant flow.

Clearly this is supported by hydra

curl -u "username:secret" -d "grant_type=client_credentials&scope=system" http://localhost:4444/oauth2/token
{"access_token":"idCzU_6Y8rYVpnjggAn900ut_VhjV4diPUHCFs3-z2w.YZUsVSMwPD11WVnOOXHRnk-IPw65HP-doa4Bs3UzPdE","expires_in":3599,"scope":"system","token_type":"bearer"}

Maybe it is usefull to add that parameter and let the generator generate the missing scope field.

Thank you

aeneasr commented 4 years ago

Thank you! If you want, you can add the scope parameter here: https://github.com/ory/hydra/blob/master/oauth2/doc.go#L163

This will then end up in the SDK

github-actions[bot] commented 2 years ago

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers a year. That does not imply that the issue has no merit! If you feel strongly about this issue

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneous you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️