fix: Backchannel Logout: Fix error log when RP responds with status code 204

SiebelsTim commented 3 months ago

According to the specification at https://openid.net/specs/openid-connect-backchannel-1_0.html#BCResponse the Relying Party must respond with a status code 200. However, it also notes that the OpenID Provider should be prepared to handle status code 204 (No Content) as a successful response as well.

Related issue(s)

This is a previously unknown bug.

Reproduction:

Configure backchannel logout
The relying party responds with a 204 status code on the backchannel logout request
Hydra logs an error

Note that this does not change any behaviour. The logged error does not have an influence whether the user is logged out or not.

Checklist

[x] I have read the contributing guidelines.
[x] I have referenced an issue containing the design document if my change introduces a new feature.
[x] I am following the contributing code guidelines.
[x] I have read the security policy.
[x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got the approval (please contact security@ory.sh) from the maintainers to push the changes.
[x] I have added tests that prove my fix is effective or that my feature works. -- Since this is only related to logging. Adding a test is difficult for me.
[x] I have added or changed the documentation. -- I don't think this is necessary

Further Comments

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.29%. Comparing base (67a85cc) to head (69cd817). Report is 2 commits behind head on master.

Files	Patch %	Lines
consent/strategy_default.go	0.00%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #3731 +/- ## ======================================= Coverage 76.29% 76.29% ======================================= Files 134 134 Lines 10214 10214 ======================================= Hits 7793 7793 Misses 1904 1904 Partials 517 517 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SiebelsTim commented 3 months ago

I am happy that the changes were approved so quickly. Do I need to do anything else?

aeneasr commented 3 months ago

Me clicking merge, sorry :)

ory / hydra