feat: use TLD per default for cookie domain

ory / integrations

Apache License 2.0

19 stars 24 forks source link

feat: use TLD per default for cookie domain #21

Closed aeneasr closed 2 years ago

aeneasr commented 2 years ago

This PR changes the behavior of the cookie detection mechanism to automatically set the cookie domain to the TLD of the request. To get the old behavior, set dontUseTldForCookieDomain to true.

Closes https://github.com/ory/integrations/issues/20

MilesNorton commented 2 years ago

@aeneasr Thanks for doing this. Looking at the tests, say if i have sub domains: x.domain.com and y.domain.com. Will it properly set it to domain.com?

aeneasr commented 2 years ago

That's the intention yes!

rostyk110 commented 2 years ago

could u make a new release please?

aeneasr commented 2 years ago

Done!

rostyk110 commented 2 years ago

thank u! <3