ory / k8s

Kubernetes Helm Charts for the ORY ecosystem.
https://k8s.ory.sh/helm
Apache License 2.0
334 stars 259 forks source link

add nodeSelector for migration jobs #425

Closed fokoenecke closed 2 years ago

fokoenecke commented 2 years ago

Preflight checklist

Describe your problem

The nodes in our kubernetes cluster as restricted on which external servers they may connect to. Thus we heavily rely on nodeSelectors to ensure our services are able to access resources like databases. Unfortunately I could not find a way to add a node selector kratos and hydra migration job yamls.

The same applies to kratos-courier and maybe other parts I don't know about.

Describe your ideal solution

If the job templates had a section

{{- with .Values.job.nodeSelector }}
  nodeSelector: {{- . | toYaml | nindent 8 }}
{{- end }}

I would be able to set a nodeSelector via --set job.nodeSelector.my/label=value

Workarounds or alternatives

I thought about extending the charts somehow or finding other ways to modify the scheduler, but couldn't find a way, yet. edit: I ended up downloading the chart, modify it and deploy from local. but that's bad, obviously.

Version

v0.21.5 kratos / v0.21.5 hydra

Additional Context

No response

Demonsthere commented 2 years ago

Hi there, I agree, we would need to update the charts globally and include the new options in all of them. Like always all contributions are welcome 😉