Closed adamstrawson closed 2 years ago
Hi there! You are correct, the values is not consistent with the rest of the ory ecosystem :/ However your method introduces a breaking change, instead I would suggest the usage of ternary operator:
{{- $annotations := ternary .Values.deployment.annotations .Values.deployment.annotation (not (empty .Values.deployment.annotations )) -}}
this format would support both and not be a breaking change :)
Please add in your PR an empty object as the default value for annotations, and some test annotations to the test overrides in the hack
folder :)
The use of
annotation
withinhydra-maester
is inconsistent with the other Ory Helm Charts, as well as it's own documentation.The
hydra-maester
documentation specifieddeployment.annotations
already, and the other charts use the same format.Checklist