ory / k8s

Kubernetes Helm Charts for the ORY ecosystem.
https://k8s.ory.sh/helm
Apache License 2.0
336 stars 259 forks source link

Add default emailTemplates #491

Closed varac closed 2 years ago

varac commented 2 years ago

See https://github.com/ory/k8s/issues/490:

The kratos.emailTemplates key is not properly rendered by helm docs, it doesn't show up in the README.md table in the first column, but in the last one under kratos.config.

varac commented 2 years ago

Beware of #490, templating the unmodified values in this PR will currently result in this error:

❯ helm -n test template kratos-test .
Error: template: kratos/templates/statefulset-mail.yaml:43:12: executing "kratos/templates/statefulset-mail.yaml" at <include "kratos.annotations.checksum" .>: error calling include: template: kratos/templates/_helpers.tpl:178:30: executing "kratos.annotations.checksum" at <include (print $.Template.BasePath "/configmap-templates.yaml") .>: error calling include: template: kratos/templates/configmap-templates.yaml:13:20: executing "kratos/templates/configmap-templates.yaml" at <.Values.configmap.annotations>: nil pointer evaluating interface {}.configmap
CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

varac commented 2 years ago

Even helm lint fails with the same issue:

❯ helm lint
==> Linting .
[ERROR] templates/: template: kratos/templates/statefulset-mail.yaml:43:12: executing "kratos/templates/statefulset-mail.yaml" at <include "kratos.annotations.checksum" .>: error calling include: template: kratos/templates/_helpers.tpl:178:30: executing "kratos.annotations.checksum" at <include (print $.Template.BasePath "/configmap-templates.yaml") .>: error calling include: template: kratos/templates/configmap-templates.yaml:13:20: executing "kratos/templates/configmap-templates.yaml" at <.Values.configmap.annotations>: nil pointer evaluating interface {}.configmap

Error: 1 chart(s) linted, 1 chart(s) failed
Demonsthere commented 2 years ago

Thanks for the issue and the PR I think we can close this, as I am providing the fix for the cm and indent in https://github.com/ory/k8s/pull/498 :)