ory / k8s

Kubernetes Helm Charts for the ORY ecosystem.
https://k8s.ory.sh/helm
Apache License 2.0
334 stars 259 forks source link

Inconsistent use of init & extra containers on jobs #507

Closed adamstrawson closed 2 years ago

adamstrawson commented 2 years ago

Preflight checklist

Describe the bug

The Hydra helm-chart job resource has an incorrectly wrapped conditional, extraContainers is wrapped within extraInitContainers conditional, meaning you cant define an extra container without also setting extraInitContainers.

Keto & Kratos was also missing extraInitContainers entirely too.

Reproducing the bug

helm install -f values.yaml ory/hydra

# values.yaml
job:
  extraContainers: |
    - name: helloworld
      image: helloword:latest

The hellowold sidecar container will not be included.

Relevant log output

No response

Relevant configuration

No response

Version

0.25.3

On which operating system are you observing this issue?

No response

In which environment are you deploying?

No response

Additional Context

No response

Demonsthere commented 2 years ago

Closed by https://github.com/ory/k8s/pull/508