fix: env DSN to be included if hydra.dsn is empty

cr1cr1 commented 2 years ago

Checklist

[x] I have read the contributing guidelines and signed the CLA.
[ ] I have referenced an issue containing the design document if my change introduces a new feature.
[x] I have read the security policy.
[x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added the necessary documentation within the code base (if appropriate).

hydra-automigrate will fail if using a secret instead of explicit hdyra.dsn because wrong condition in the helm template: https://github.com/ory/k8s/blob/6a22a343a3114b052e3edfc250fe155323525a39/helm/charts/hydra/templates/job-migration.yaml#L60

This bug was introduced in release v0.25.4

MOZGIII commented 2 years ago

Not passing the DSN is actually a feature: you can pass a custom dynamically constructed DSN vie extraEnv.

Demonsthere commented 6 months ago

closing as stale