ory / k8s

Kubernetes Helm Charts for the ORY ecosystem.
https://k8s.ory.sh/helm
Apache License 2.0
336 stars 259 forks source link

feat: add tolerations to job-migration #552

Closed AsyaZav closed 1 year ago

AsyaZav commented 1 year ago

We need to have an ability to set tolerantions for Job entity because in other case it's impossible to make auto-migration pod in kube cluster where all nodes have the taints

Related Issue or Design Document

Checklist

Further comments

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

Demonsthere commented 1 year ago

Hello there! :) This feature makes complete sense to me and we can add it right away :) But I would ask to expand the PR for all charts with db requirements (hydra, keto, kratos) for the sake of consistency :)

AsyaZav commented 1 year ago

Thanks for productive feedback. I took into account your comments ))

vinckr commented 1 year ago

Hello @AsyaZav Congrats on merging your first PR in Ory 🎉 ! Your contribution will soon be helping secure millions of identities around the globe 🌏. As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community. Please drop me an email and I will forward you the form to claim your Ory swag!