DSN environmental variable is not set optionally

blumTom commented 11 months ago

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[ ] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Ory Network Project

No response

Describe the bug

Location: https://github.com/ory/k8s/blob/d3ffdadf111d535729a59e72998ec7cee8d457f9/helm/charts/kratos/templates/cleanup-cron-job.yaml#L74

The condition does not evaluate properly. The intention here is to set the DSN environmental variable optionally, but with this condition it is always set. However, it is a good idea to set the DSN environmental variable optionally to give the user the possibility to define a custom source of this value via the "cleanupCronjobExtraEnv" variable. In addition to that this should be consistent to all other occurrences of DSN environmental variable definitions.

Reproducing the bug

Do not set the dsn config value.

Relevant log output

No response

Relevant configuration

dsn:

Version

0.38.0 (helm version)

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

dlahn commented 6 months ago

fixed by #678

Demonsthere commented 6 months ago

closed by https://github.com/ory/k8s/pull/678

ory / k8s