Keto chart uses `strategy` from wrong location in values.yaml

[jagregory]

Preflight checklist

• [X] I could not find a solution in the existing issues, docs, nor discussions.
• [X] I agree to follow this project's Code of Conduct.
• [X] I have read and am following this repository's Contribution Guidelines.
• [X] I have joined the Ory Community Slack.
• [X] I am signed up to the Ory Security Patch Newsletter.

Ory Network Project

No response

Describe the bug

The Keto Helm chart has the deployment strategy in the values.yaml in this location:

https://github.com/ory/k8s/blob/ae7785ea32fd775445de9fff46e827ea58d06283/helm/charts/keto/values.yaml#L266-L272

But the actual Deployment spec references just .Values.strategy:

https://github.com/ory/k8s/blob/ae7785ea32fd775445de9fff46e827ea58d06283/helm/charts/keto/templates/deployment.yaml#L42-L43

This results in the Keto Deployment being created with strategy: null, which then defaults to RollingUpdate anyway so it's not obvious it's happening.

Reproducing the bug

Try to override the Keto deployment strategy by modifying the default value in the values.yaml and see it has no effect. You have to put the strategy key at the top level to make it work.

Relevant log output

No response

Relevant configuration

No response

Version

0.44.0

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response