feat: template extraEnv

jagregory commented 2 weeks ago

Similar to #703, it's useful to be able to template extra environment variables (especially DSN). For example, when using several Ory components and multiple environments you can template the DSNs to a shared value instead of needing to set each individually.

Checklist

[x] I have read the contributing guidelines and signed the CLA.
[ ] I have referenced an issue containing the design document if my change introduces a new feature.
[x] I have read the security policy.
[x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added the necessary documentation within the code base (if appropriate).

Demonsthere commented 2 weeks ago

Hi there! I have nothing agains this feature, as it does not modify the default behaviour, not is it a breaking change, but please add a few words to the documentation of the components showing an example plus update at least one of the values in hacks/values to have this option be checked in the CI :)

jagregory commented 2 weeks ago

Will do, thanks Jakub!

On Tue, 17 Sep 2024 at 5:10 pm, Jakub Błaszczyk @.***> wrote:

Hi there! I have nothing agains this feature, as it does not modify the default behaviour, not is it a breaking change, but please add a few words to the documentation of the components showing an example plus update at least one of the values in hacks/values to have this option be checked in the CI :)

— Reply to this email directly, view it on GitHub https://github.com/ory/k8s/pull/704#issuecomment-2354722721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACUTFFA5MJ2UAVVKXII63ZW7IYFAVCNFSM6AAAAABOKVX7JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJUG4ZDENZSGE . You are receiving this because you authored the thread.Message ID: @.***>

jagregory commented 1 week ago

@Demonsthere FYI I've updated this PR and #703, let me know if you have any other feedback. Thanks

ory / k8s

feat: template extraEnv #704

Checklist