ory / kratos-selfservice-ui-node

Apache License 2.0
314 stars 207 forks source link

fix: incorrect implementation of filterNodesByGroups #326

Closed hperl closed 6 months ago

hperl commented 6 months ago

Merging this will fix E2E failures on Kratos master.

Related Issue or Design Document

Checklist

Further comments

hperl commented 6 months ago

Add a test?

The kratos-selfservice-ui-node repo "traditionally" has no tests:

https://github.com/ory/kratos-selfservice-ui-node/blob/541f3bf14a31db4a3fd2f1f10c5d9ab6009c9f9a/package.json#L24

This leads to situations where changes in this repo can break Kratos E2E tests on Kratos master (where the code in this repo is thoroughly tested).

To fix this, I suggest moving this repo into a ui folder in the Kratos repo and have the E2E tests depend on the code in that location. If necessary (I think because the docs reference this repo) we can export the changes with Copybara.

WDYT?