ory / kratos

The most scalable and customizable identity server on the market. Replace your Homegrown, Auth0, Okta, Firebase with better UX and DX. Has all the tablestakes: Passkeys, Social Sign In, Multi-Factor Auth, SMS, SAML, TOTP, and more. Written in Go, cloud native, headless, API-first. Available as a service on Ory Network and for self-hosters.
https://www.ory.sh/?utm_source=github&utm_medium=banner&utm_campaign=kratos
Apache License 2.0
11.23k stars 961 forks source link

Logout Http Code doesn't match Docs #1648

Closed like-a-bause closed 6 months ago

like-a-bause commented 3 years ago

A successful logout results in a 303: https://github.com/ory/kratos/blob/11bdc4a815bd1e264d0ccbf42ca56f76e6ab1bbc/selfservice/flow/logout/handler.go#L277 the documentation however states a 302: https://github.com/ory/kratos/blob/11bdc4a815bd1e264d0ccbf42ca56f76e6ab1bbc/selfservice/flow/logout/handler.go#L227

I don't know if this change was made intentionally or by mistake. One of these lines needs to be updated.

aeneasr commented 3 years ago

Thank you! Feel free to correct it in a PR :)

robertlagrant commented 1 year ago

@aeneasr I think this is now closeable. Looks fixed. https://github.com/ory/kratos/blob/1064b3296faccf66301d412bf0f7c3d6da09c8ef/selfservice/flow/logout/handler.go#L277

github-actions[bot] commented 6 months ago

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️