feat : update oidc tokens on login flow

david972 commented 2 years ago

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[ ] This issue affects my Ory Cloud project.
[X] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Describe your problem

Currently Kratos record the token during the registration and the setting.

If the access_token recorded has expired in the meanwhile or tokens has been revoked it would be useful to update them. I know in case of expiration we can use the refresh token but not in case of revocation.

Do you see a security concern to update the tokens on login ?

Describe your ideal solution

I suggest to update oidc tokens on login flow

Workarounds or alternatives

No workaround available at this moment

Version

from v0.8.0-alpha.1

Additional Context

No response

aeneasr commented 2 years ago

👍

PRs welcomed!

fehrnah commented 2 years ago

If no one is working on this, I would like to give it a try

aeneasr commented 2 years ago

sure :)

david972 commented 2 years ago

on this one #2428

fehrnah commented 2 years ago

Looking at your work, I think it would be easy to add #2326 on top of it. I can do it, but I am unsure what the best way to merge it would be.

david972 commented 1 year ago

not sure is related

AndersSoee commented 1 year ago

Would it make sense to store these update tokens on the flow instead of (or in addition to) on the identity? That would remove some possible race conditions, and would make it easier to couple an identity token to a flow that increases assurance level to perform critical tasks.

github-actions[bot] commented 3 months ago

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

open a PR referencing and resolving the issue;
leave a comment on it and discuss ideas on how you could contribute towards resolving it;
leave a comment and describe in detail why this issue is critical for your use case;
open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

ory / kratos