ory / kratos

The most scalable and customizable identity server on the market. Replace your Homegrown, Auth0, Okta, Firebase with better UX and DX. Has all the tablestakes: Passkeys, Social Sign In, Multi-Factor Auth, SMS, SAML, TOTP, and more. Written in Go, cloud native, headless, API-first. Available as a service on Ory Network and for self-hosters.
https://www.ory.sh/?utm_source=github&utm_medium=banner&utm_campaign=kratos
Apache License 2.0
11.23k stars 961 forks source link

use 204 instead of 404 for AdminDeleteIdentitySessions #2382

Closed frederikhors closed 5 months ago

frederikhors commented 2 years ago

Preflight checklist

Describe your problem

Currently if I use V0alpha2Api.AdminDeleteIdentitySessions it returns 404 if no sessions are found.

I'm wondering if this is useful since that method is used to ensure that all sessions are deleted, whether they are present or not.

Or maybe that's not the meaning of that method and we need another one?

Especially since in Go I get an error when I really don't want it for that case.

httpResponse, err := kratos.V0alpha2Api.AdminDeleteIdentitySessions(ctx, id).Execute()
  if err != nil {
    if httpResponse.StatusCode == 404 {
      return nil
    }

  return err
}

Describe your ideal solution

It would make sense to return 204 in any case!

@aeneasr said: https://github.com/ory/kratos/discussions/2381#discussioncomment-2533312.

Version

0.9.0-alpha.3

github-actions[bot] commented 1 year ago

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

frederikhors commented 1 year ago

No stale.

github-actions[bot] commented 6 months ago

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️