jonas-jonas
commented
1 year ago I am not entirely sure, I understand the issue, but let me try to clarify a few things:
The JSON coming from Kratos (that contains the ui fields) is made to be rendered as is, using some kind of translation layer, such as a library, to convert it to HTML, or native UI elements. So naturally, Kratos expects the fields that are then submitted as part of POST request to match those.
Couldn't you just add the traits. prefix on your server side before submission?
mannie-exe
JoblersTune
christoph-kluge
Preflight checklist
Ory Network Project
No response
Describe the bug
TL;DRis that`POST:/self-service/registration?flow={id}`"validates" form data as<key>instead oftraits.<key>, unsuccessfully, according to a400(click me to read more)I'm trying to proxy any IDP request from the client via a Node.js server. Setting the right `content-type` and cookies is not a problem, and Kratos seems to recognize my requests. Doing a `POST` to the registration service URL (for the password method) fails. Here's an example HTTP `POST` body: ``` csrf_token=WKujP4sPg8%2BJu7pLqmBNupQu9Bu5c%2Fzwn8Yq32R6NQp9Zxu0Vb1NIoGNn%2Bqj4ZsW%2BctByKKvvwDBpu7lC7XIWA%3D%3D&traits.name=
Here's what the CLI says during
```shell time=2023-09-08T21:59:59-07:00 level=info msg=started handling request http_request=map[headers:map[accept:application/json content-type:application/x-www-form-urlencoded cookie:REDACTED] host:REDACTED method:POST path:/self-service/registration query:REDACTED remote:192.168.88.1:63122 scheme:https] time=2023-09-08T21:59:59-07:00 level=info msg=Encountered self-service flow error. audience=audit error=map[message:I[#] S[#/required] missing properties: "name", "date_of_birth", "email"POST:And here are the self-service responses before and after the registration request `POST -> kratos://self-service/registration?flow={id}`.
Before
```json { "id": "99a64fa5-e607-4dcd-9818-1c795ced3c0c", "type": "browser", "expires_at": "2023-09-09T07:11:14.2743837Z", "issued_at": "2023-09-09T06:56:14.2743837Z", "request_url": "POST(afterGET -> kratos://self-service/registration/browser):After
```json { "id": "99a64fa5-e607-4dcd-9818-1c795ced3c0c", "type": "browser", "expires_at": "2023-09-09T07:11:14.2743837Z", "issued_at": "2023-09-09T06:56:14.2743837Z", "request_url": "POST:NOTE: Both are requests with `Content-Type`: `application/json`, and the `POST` specifically accepts `application/x-www-form-urlencoded; charset=utf-8` (I added the charset after something I noticed further down). Alongside `traits.name`, `traits.date_of_birth`, and `traits.email`, the `POST` response has `name`, `date_of_birth`, and `email` nodes as well. I'm not sure if this is the problem, but it's the only difference I can see -- the latter are the only nodes with validation error messages while the former are populated with the correct, url-encoded values given to the `POST` body. So I tried changing the `required` properties in my schema from `
Before `POST` looks the same.
After
```json { "id": "0b862e5e-cdc5-477a-9103-d7f633bb41f2", "type": "browser", "expires_at": "2023-09-09T07:21:33.0681115Z", "issued_at": "2023-09-09T07:06:33.0681115Z", "request_url": "POST:Now all the missing keys in the response are named `traits\\.key`. Am I missing a character set configuration somewhere? Reading the [docs](https://www.ory.sh/docs/kratos/debug/troubleshooting), I see that there may be issues if trying to complete a flow from across browsers. Would I be running into that? I'm not sure how to check. I should mention I'm using the node HTTP2 client, and both Kratos and my proxy are on the same TLD -- served with TLS. My request looks something like: ```js idp_client.connection.request({ ":method": method, ":path": idp_url, Accept: accept_mime, // "application/json" ...data.headers, // content-type + cookie } ``` Is this a bug, or am I missing a step in the self-service process? ~~I did notice that `GET -> kratos://self-service/registration/browser` itself returns the user interface, so I never bother hitting `GET -> kratos://self-service/registration/flows=${id}`. Could that be an issue?~~ (Apparently [that's fine](https://www.ory.sh/docs/kratos/reference/api#tag/frontend/operation/updateRegistrationFlow) during requests that accept `application/json`.) Other than that, I get the same results from the Node.js client as I do from Postman. A `400` bad request with mentions of missing properties (either `name` or `traits\\.name` depending on my schema at that moment). If this is an issue covered in the docs, I'd be happy to close this issue ASAP. Otherwise, any help would be lovely.
P.S. My identity schema, for completeness' sake (
```json { "$schema": "http://json-schema.org/draft-07/schema#", "title": "Player", "description": "User/player schema", "type": "object", "properties": { "traits": { "type": "object", "properties": { "name": { "title": "Display Name", "description": "A player's display name", "type": "string" }, "date_of_birth": { "title": "Date of Birth", "description": "A player's date of birth", "type": "string", "format": "date" }, "email": { "title": "E-Mail", "description": "A player's e-mail address", "type": "string", "format": "email", "ory.sh/kratos": { "credentials": { "password": { "identifier": true } }, "verification": { "via": "email" }, "recovery": { "via": "email" } }, "maxLength": 320 } } } }, "required": ["name", "date_of_birth", "email"], "additionalProperties": false } ```traits.keychange reverted):Reproducing the bug
Short
GET->kratos://self-service/registration/browserPOST->kratos://self-service/registration?flow=${id}400- Bad Request; missing propertiesComplete
/GET->/user/joinGET->kratos://self-service/registration/browserduring/user/joinPOST->/user/joinPOST->kratos://self-service/registration?flow=${id}400due to body missing required propertiesRelevant log output
Relevant configuration
No response
Version
v1.0.0
On which operating system are you observing this issue?
Windows
In which environment are you deploying?
Other
Additional Context
No response