ory / kratos

The most scalable and customizable identity server on the market. Replace your Homegrown, Auth0, Okta, Firebase with better UX and DX. Has all the tablestakes: Passkeys, Social Sign In, Multi-Factor Auth, SMS, SAML, TOTP, and more. Written in Go, cloud native, headless, API-first. Available as a service on Ory Network and for self-hosters.
https://www.ory.sh/?utm_source=github&utm_medium=banner&utm_campaign=kratos
Apache License 2.0
11.12k stars 954 forks source link

fix(oidc): grace period for continuity container on oidc callbacks #3915

Closed aeneasr closed 4 months ago

aeneasr commented 4 months ago

Related issue(s)

Checklist

Further Comments

aeneasr commented 4 months ago

This was merged as part of another PR

aeneasr commented 4 months ago

Or was it?

aeneasr commented 4 months ago

It was not.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 66.07143% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 78.08%. Comparing base (5288bc7) to head (926ed2a). Report is 1 commits behind head on master.

Files Patch % Lines
continuity/manager_cookie.go 40.00% 5 Missing and 4 partials :warning:
x/cookie.go 0.00% 6 Missing :warning:
persistence/sql/persister_continuity.go 75.00% 1 Missing and 2 partials :warning:
selfservice/strategy/oidc/strategy.go 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3915 +/- ## ========================================== + Coverage 78.02% 78.08% +0.05% ========================================== Files 362 362 Lines 25296 25341 +45 ========================================== + Hits 19737 19787 +50 + Misses 4047 4038 -9 - Partials 1512 1516 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.