Open aeneasr opened 1 month ago
OK - we need a proper ID structure then in Ory Elements to deal with that but I agree
Am 24.05.2024 um 10:22 schrieb Patrik @.***>: @zepatrik commented on this pull request.
In text/message_system.go:
@@ -13,3 +13,11 @@ func NewErrorSystemGeneric(reason string) Message { }), } } + +func NewErrorSelfServiceNoMethodsAvailable() Message {
I don't think that we should add any element specific messages here. Kratos is headless, and should only care about the messages it uses. In the previous Ory elements version, we also had two sources of messages for translations, and had a small script to merge the two: https://github.com/ory/elements/blob/a93569f94b252ba193658199559f944162f9b6ab/scripts/generate-locales.ts#L53-L80 I strongly suggest to not add any messages here that are not part of this codebase, as it will become a nightmare to maintain down the road.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
Previously we used inline definitions, e.g. https://github.com/ory/elements/blob/a93569f94b252ba193658199559f944162f9b6ab/src/react-components/ory/user-auth-card.tsx#L131-L134 This is convenient for developing, as everything is in-place. For IDs we used kind of a namespace approach, but the main mechanism to ensure uniqueness of IDs is the tooling that comes with react-intl. It extracts all messages from the code and generates the "default" translation, from witch you then create all other translations.
Attention: Patch coverage is 82.08000%
with 112 lines
in your changes missing coverage. Please review.
Project coverage is 78.31%. Comparing base (
e0001b0
) to head (11a28a1
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Related issue(s)
Checklist
Further Comments