ory / kratos

The most scalable and customizable identity server on the market. Replace your Homegrown, Auth0, Okta, Firebase with better UX and DX. Has all the tablestakes: Passkeys, Social Sign In, Multi-Factor Auth, SMS, SAML, TOTP, and more. Written in Go, cloud native, headless, API-first. Available as a service on Ory Network and for self-hosters.
https://www.ory.sh/?utm_source=github&utm_medium=banner&utm_campaign=kratos
Apache License 2.0
11.32k stars 963 forks source link

feat: add explicit config flag for secure cookies #4180

Closed aeneasr closed 3 weeks ago

aeneasr commented 3 weeks ago

Adds a new config flag for session and all other cookies. Falls back to the previous behavior of using the dev mode to decide if the cookie should be secure or not.

Related issue(s)

Checklist

Further Comments

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.57%. Comparing base (77beb4d) to head (c34b353). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
driver/config/config.go 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4180 +/- ## ========================================== - Coverage 78.57% 78.57% -0.01% ========================================== Files 380 380 Lines 27103 27111 +8 ========================================== + Hits 21297 21303 +6 - Misses 4188 4190 +2 Partials 1618 1618 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.