Conventional commits fails with false negative

ory / meta

A place where we plan and schedule our open source activities and track cross-project and ory-wide issues

Apache License 2.0

17 stars 13 forks source link

Conventional commits fails with false negative #158

Closed aeneasr closed 2 years ago

aeneasr commented 2 years ago

This PR has the correct title https://github.com/ory/kratos/pull/2593 but the CI failed for conventional commits. Can you PTAL @kevgo ? TY!

vinckr commented 2 years ago

i think its because sdk is not part of the scopes

          scopes: |
            blog
            cms
            deps
            docs
            home
            hydra
            keto
            kratos
            stats

kevgo commented 2 years ago

Yes, a few scopes are missing: sdk, console, backoffice. This is the type of feedback we need to fine-tune this action. @zepatrik has already sent a PR to upstream: https://github.com/amannn/action-semantic-pull-request/pull/193

kevgo commented 2 years ago

This is fixed now and can be closed.