Logo on OIDC Generic Provider Login, Signup page

linn-affinidi commented 1 year ago

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[X] This issue affects my Ory Network project.
[X] I have joined the Ory Community Slack.
[X] I am signed up to the Ory Security Patch Newsletter.

Describe your problem

Issue: After OIDC Generic Provider is added via Social Sign-in page (console.ory.sh/projects/../social-signin), logo for Generic Provider is missing on Login, Signup page. There is no option to add logo on Theme Page (console.ory.sh/projects/../account-experience/theming) as well.

Describe your ideal solution

Feature Request: An option to upload custom logo for Generic OIDC/OAuth2 Provider and display on Login, Signup page similar like other provider (eg: Microsoft).

Workarounds or alternatives

Alternative Solution: Or may be support custom css with image url.

Version

all versions

Additional Context

No response

kmherrmann commented 1 year ago

Thanks for the report, i've added this to our backlog.

We should add a "Logo URI" option to the generic OIDC provider config and use that, rather than making it an account experience feature - that way it works in custom UIs, too, and it scales better to multiple custom providers

github-actions[bot] commented 1 month ago

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

open a PR referencing and resolving the issue;
leave a comment on it and discuss ideas on how you could contribute towards resolving it;
leave a comment and describe in detail why this issue is critical for your use case;
open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

aeneasr commented 1 month ago

In Ory Elements v2 we auto generate an icon. However, it’s still not possible to customize it.

ory / network