ory / network

Ory runs a global end-to-end security infrastructure for humans, robots, and servers. We build and use open source software.
Apache License 2.0
81 stars 6 forks source link

Custom Domain CORS allowed origins history is lost on save #341

Closed adamstrawson closed 1 year ago

adamstrawson commented 1 year ago

Preflight checklist

Ory Network Project

No response

Describe the bug

When editing an existing custom domain, existing values within CORS Origins are overwritten, and previous values are lost.

It's also not possible to remove existing values (although this bug removes them for you)

Reproducing the bug

1) Login to Ory Network and navigate to /custom-domains, and edit an existing domain 2) Enter a value in CORS Origins and hit Save. 3) Edit the same domain again, and enter a different value in CORS Origins, and hit save.

The value in step 2 is replaced by the value in step 3.

Previous values

Screenshot 2023-09-26 at 16 09 53

Editing to add a new value

Screenshot 2023-09-26 at 16 10 30

Previous value is replaced with new value

Screenshot 2023-09-26 at 16 10 37

Relevant log output

No response

Relevant configuration

No response

Version

N/A

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

kmherrmann commented 1 year ago

@mszekiel can you take a look, please?

jonas-jonas commented 1 year ago

Thanks again for the report, a fix should finally be live soon.