Account Experience Registration Crash

ory / network

Ory runs a global end-to-end security infrastructure for humans, robots, and servers. We build and use open source software.

Apache License 2.0

81 stars 6 forks source link

Account Experience Registration Crash #389

Closed ahmedrowaihi closed 4 months ago

ahmedrowaihi commented 4 months ago

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[ ] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Ory Network Project

No response

Describe the bug

some times ui flow returns null

Reproducing the bug

Create Project
Go To Account Experience
Click Registration
Observe error

Relevant log output

No response

Relevant configuration

No response

Version

WEBSITE

On which operating system are you observing this issue?

None

In which environment are you deploying?

Other

Additional Context

https://console.ory.sh

vinckr commented 4 months ago

Hey @ahmedrowaihi I am not able to reproduce this on a fresh project.

Do you maybe have some browser plugins / VPN running or something along those lines?

ahmedrowaihi commented 4 months ago

Hey @ahmedrowaihi I am not able to reproduce this on a fresh project.

Do you maybe have some browser plugins / VPN running or something along those lines?

no, it appeared once, in some cases registration flow.ui.nodes are null

we need to handle that

ahmedrowaihi commented 4 months ago

if you look close in the code, it doesn't handle null case at all

vinckr commented 4 months ago

Hey @ahmedrowaihi I am not able to reproduce this on a fresh project. Do you maybe have some browser plugins / VPN running or something along those lines?

no, it appeared once, in some cases ui.nodes are null

we need to handle that

I see. Can you share more details in what cases this happens? Definitely need some way to reproduce this.

ahmedrowaihi commented 4 months ago

@vinckr

create new account
go to settings
disable password
hit save
go to account experience
switch to registration tab
observe Sorry I couldn't trim the video, but check from second 00:42 https://github.com/ory/elements/assets/67356781/ba303bfe-31f3-4962-87f1-7062c0830707

vinckr commented 4 months ago

Thanks for the video, that makes it clear! That should not happen. I guess its a "misconfiguration" if you remove all authentication methods, but still should not result in a crash.