Adjusting data-mapping for social sign-in overwrites provider

Sese-Schneider commented 2 months ago

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[X] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Ory Network Project

https://gracious-hypatia-b9te8t22yp.projects.oryapis.com

Describe the bug

We have a custom generic social sign-in provider with the provider: salesforce. The UI currently doesn't support salesforce.

When adjusting the generic providers data-mapping via the UI, the provider field is overwritten back to generic.

Reproducing the bug

Create a generic social sign-in provider
Update the provider field to salesforce via the CLI
Go to the Network UI and change the data mapping

The provider field (config viewed via CLI) is reset to generic.

Relevant log output

No response

Relevant configuration

{
  "client_id": "[REDACTED]",
  "client_secret": "[REDACTED]",
  "id": "[REDACTED]",
  "issuer_url": "https://testissuer.com",
  "label": "Salesforce",
  "mapper_url": "[REDACTED]",
  "provider": "salesforce",
  "scope": [
    "openid",
    "email",
    "profile"
  ]
}

Version

current

On which operating system are you observing this issue?

Ory Network

In which environment are you deploying?

Ory Network

Additional Context

No response

aeneasr commented 2 months ago

The ask is to add Salesforce as an option to the UI?

jonas-jonas commented 2 months ago

This has been done, and will be released next week to production. Thanks for the contribution in Kratos @Sese-Schneider

ory / network