Open adamstrawson opened 2 years ago
Hello there! As this is a CRD change, you are right it can be breaking. In this situation we could do one of the following:
strip_path
which would work alongside stripPath
, and mark this as deprecatedv1alpha2
with the new fieldHowever, I cannot give you any indication when we could add either of the solutions 😞
Describe the bug
There is an inconstancy within the CRD when defining
upstream.strip_path
.The Ory Oathkeeper documentation, and some references within the CRD uses snake case
strip_path
, however the CRD expects this to be camel casestripPath
.Snake Case references: Documentation Rule_type_tests.go Rule_json.go
Camel case reference rule_types.go
Expected behavior
The CRD should ideally match that of the Ory documentation for a standard rule outside of the CRD, as snake case
strip_path
Environment CRD version: v1alpha1
I would contribute a PR for this, but aware that it'll be a breaking change for those who have already implemented as
stripPath
, so not sure how best to action this.