ory / oathkeeper-maester

Kuberenetes CRD Controller for Ory Oathkeeper. :warning: Maintained by the community, not an official Ory project!
Apache License 2.0
33 stars 20 forks source link

Inconsistancy with upstream.strip_path #56

Open adamstrawson opened 2 years ago

adamstrawson commented 2 years ago

Describe the bug

There is an inconstancy within the CRD when defining upstream.strip_path.

The Ory Oathkeeper documentation, and some references within the CRD uses snake case strip_path , however the CRD expects this to be camel case stripPath.

Snake Case references: Documentation Rule_type_tests.go Rule_json.go

Camel case reference rule_types.go

Expected behavior

The CRD should ideally match that of the Ory documentation for a standard rule outside of the CRD, as snake case strip_path

Environment CRD version: v1alpha1

I would contribute a PR for this, but aware that it'll be a breaking change for those who have already implemented as stripPath, so not sure how best to action this.

Demonsthere commented 2 years ago

Hello there! As this is a CRD change, you are right it can be breaking. In this situation we could do one of the following:

However, I cannot give you any indication when we could add either of the solutions 😞