ory / oathkeeper

A cloud native Identity & Access Proxy / API (IAP) and Access Control Decision API that authenticates, authorizes, and mutates incoming HTTP(s) requests. Inspired by the BeyondCorp / Zero Trust white paper. Written in Go.
https://www.ory.sh/?utm_source=github&utm_medium=banner&utm_campaign=hydra
Apache License 2.0
3.2k stars 349 forks source link

feat: preserve_host feature for oauth2_introspect #1131

Closed alnr closed 10 months ago

alnr commented 10 months ago
codecov[bot] commented 10 months ago

Codecov Report

Merging #1131 (aa9555c) into master (5bf9b70) will decrease coverage by 0.07%. Report is 1 commits behind head on master. The diff coverage is 87.17%.

:exclamation: Current head aa9555c differs from pull request most recent head 50be903. Consider uploading reports for the commit 50be903 to get more accurate results

@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
- Coverage   78.22%   78.16%   -0.07%     
==========================================
  Files          80       80              
  Lines        3863     3898      +35     
==========================================
+ Hits         3022     3047      +25     
- Misses        566      576      +10     
  Partials      275      275              
Files Changed Coverage Δ
api/health.go 0.00% <ø> (ø)
metrics/prometheus.go 95.74% <ø> (ø)
credentials/fetcher_default.go 62.00% <64.28%> (-3.78%) :arrow_down:
driver/registry_memory.go 90.45% <100.00%> (ø)
middleware/grpc_middleware.go 72.41% <100.00%> (ø)
pipeline/authn/authenticator_bearer_token.go 76.05% <100.00%> (+1.81%) :arrow_up:
pipeline/authn/authenticator_cookie_session.go 81.03% <100.00%> (+0.85%) :arrow_up:
pipeline/authn/authenticator_jwt.go 83.87% <100.00%> (+0.82%) :arrow_up:
...e/authn/authenticator_oauth2_client_credentials.go 73.88% <100.00%> (ø)
...peline/authn/authenticator_oauth2_introspection.go 81.72% <100.00%> (+1.72%) :arrow_up:
... and 5 more
aeneasr commented 10 months ago

Looks like the changes are causing issues with the cache!

alnr commented 10 months ago

Looks like the changes are causing issues with the cache!

I've seen this flake before. Must be something internal to ristretto. Couldn't reproduce it locally, even with go test -count=100 🤷