ory / oathkeeper

A cloud native Identity & Access Proxy / API (IAP) and Access Control Decision API that authenticates, authorizes, and mutates incoming HTTP(s) requests. Inspired by the BeyondCorp / Zero Trust white paper. Written in Go.
https://www.ory.sh/?utm_source=github&utm_medium=banner&utm_campaign=hydra
Apache License 2.0
3.2k stars 349 forks source link

fix: update regex engine to support possessive match and lookbehind syntaxes #1147

Open cmmoran opened 5 months ago

cmmoran commented 5 months ago

Update the regexp to conditionally (naively?) change the current start,end delimiters for the regexp from the hard-coded '<','>' to '{','}' when the compiler encounters a pattern that has syntax that includes '(?<' or '(?>' organically.

BREAKING CHANGES: None

Related issue(s)

Relates:

441

Fixes:

1089

Checklist

Further Comments

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.88%. Comparing base (8fc9b7a) to head (ae8fb6e). Report is 7 commits behind head on master.

:exclamation: Current head ae8fb6e differs from pull request most recent head e3e9566

Please upload reports for the commit e3e9566 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1147 +/- ## ========================================== - Coverage 77.90% 77.88% -0.03% ========================================== Files 80 80 Lines 3929 4047 +118 ========================================== + Hits 3061 3152 +91 - Misses 595 616 +21 - Partials 273 279 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.