Open ottingbob opened 5 months ago
Curious to hear suggestions on what may be an alternative approach to get a similar outcome & would be happy to try and make the changes needed for any feedback to help enable that
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.81%. Comparing base (
8fc9b7a
) to head (2d97c76
). Report is 6 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Under the hood
ory/oathkeeper
uses https://github.com/ory/graceful to shutdown the HTTP proxy. Thegraceful
package provides a constant calledDefaultShutdownTimeout
which sets the timeout to be5
seconds.We have an application that can take up to
60
seconds to finish processing requests and we need a solution to be able to change this shutdown time in order for those requests to complete successfully.As a result, we need a way to configure
oathkeeper
to bump up that timeout and the implementation has a flag that will be able to override the global variable set in thegraceful
package. Although this does not seem like the most ideal solution it provides a way for us to change that value.Curious to hear suggestions on what may be an alternative approach to get a similar outcome & would be happy to try and make the changes needed for any feedback to help enable that.
Checklist