search

ory / oathkeeper

A cloud native Identity & Access Proxy / API (IAP) and Access Control Decision API that authenticates, authorizes, and mutates incoming HTTP(s) requests. Inspired by the BeyondCorp / Zero Trust white paper. Written in Go.
https://www.ory.sh/?utm_source=github&utm_medium=banner&utm_campaign=hydra
Apache License 2.0
3.25k stars 359 forks source link

Inconsistent Environment Variable Docs #121

Closed bensont1 closed 6 years ago

bensont1 commented 6 years ago

For consistency, should be HTTP_TLS_CERT_PATH and HTTP_TLS_KEY_PATH

certString, keyString := viper.GetString("HTTP_TLS_CERT"), viper.GetString("HTTP_TLS_KEY") certPath, keyPath := viper.GetString("HTTP_TLS_CERT_PATH"), viper.GetString("HTTP_TLS_KEY_PATH")

https://github.com/ory/oathkeeper/blob/26fdda126a9b322e5310a2a3a3ed83949f640d2c/cmd/helper_messages.go#L179

aeneasr commented 6 years ago

I'm confused, isn't that the case already?

aeneasr commented 6 years ago

Oh, it's HTTP and HTTPS, thanks!

bensont1 commented 6 years ago

@aeneasr Sorry I should have been more clear, the docs in helper_messages.go shows the Environment variable as HTTPS_TLS_CERT_PATH but the code uses HTTP_TLS_CERT_PATH. Since I was looking at only the docs initially, took me a little while to figure out why it wasn't using the certs. Just wanted to make sure other people who look at the docs don't go in a circle figuring it out :)

fredbi commented 6 years ago

To be consistent with hydra, I am going to move them all to HTTPS. I let live the same inconsistent setup in keto. ok to make this all HTTTPS_xxx like with hydra?

bensont1 commented 6 years ago

Yeah it should be HTTPS, maybe only two T’s :)

On Oct 11, 2018, at 12:20 AM, fredbi notifications@github.com<mailto:notifications@github.com> wrote:

To be consistent with hydra, I am going to move them all to HTTPS. I let live the same inconsistent setup in keto. ok to make this all HTTTPS_xxx like with hydra?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ory/oathkeeper/issues/121#issuecomment-428848061, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFolT8gktFcbZZXAq2FPAEyceiQkaU49ks5ujvEwgaJpZM4W9sqv.