ory / sdk

The place where ORY's SDKs are being auto-generated
Apache License 2.0
141 stars 85 forks source link

chore: update java SDK to OpenAPI Generator 6.0.1 #210

Closed jonas-jonas closed 2 years ago

jonas-jonas commented 2 years ago

Related Issue or Design Document

Related to #209

Checklist

Further comments

jonas-jonas commented 2 years ago

I was actually thinking about how we can make this process a bit easier for the future. Maven is quite limiting in what it allows to be shared across multiple pom.xmls and in general I'd prefer using Gradle instead. There are a few articles on releasing to maven central from Gradle here:

This would have the benefit that we can manage external dependency versions & the publishing tasks in one central place and then just include/copy it in the generation process. I'd be happy to look into this, but I think there are other priorities for now ;)

As an aside: Open API already generates Gradle files, so it's just a matter of adjusting those. I'll open an issue here for it if that's fine with you and there was no specific reason for using maven here.

Nice! YOu still need to update the version for openapi for java in the scripts/generate file :)

I think this is it, right?

https://github.com/ory/sdk/pull/210/files#diff-25806c0c4c68cee274f0c43c1b0ed2c9579bea4c3816903bfad038249cf7e934R70

aeneasr commented 2 years ago

As an aside: Open API already generates Gradle files, so it's just a matter of adjusting those. I'll open an issue here for it if that's fine with you and there was no specific reason for using maven here.

Perfect! Let's do that