Update revokeOAuth2LoginSessions client API to include the sid parameter

kabirbaidhya commented 1 year ago

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[X] This issue affects my Ory Network project.
[ ] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Describe your problem

With https://github.com/ory/hydra/pull/3450 merged, the revokeOAuth2LoginSessions API now supports revoking login sessions by sid but I can see that it's not reflected in the client SDK yet.

It still only accepts subject and not sid. https://github.com/ory/sdk/blob/master/clients/client/typescript/api.ts#L14908-L14911

When are you planning to release this change in ory/hydra and @ory/hydra-client package?

Describe your ideal solution

Update the Client SDK to reflect the recent updates on ory/hydra so that it's reflected in @ory/hydra-client.

Workarounds or alternatives

N/A

Version

v2.0.2

Additional Context

No response

jonas-jonas commented 1 year ago

Thanks for the question. ory/client is kept in sync with what is running in the Ory Network. Hydra was not yet updated there, hence why the parameter is not available in the SDK yet.

If you're self-hosting, the SDK will be updated with the next Hydra update. That should be right around the corner. If that's not early enough, you can also build the SDK yourself from the Open API schema in ory/hydra.

jonas-jonas commented 1 year ago

We are in the process of updating Hydra in the Ory Network now, but I just realized, that you were talking about a self-hosted Hydra instance with the standalone SDK, which now includes the updates, since last week. Closing this issue.

ory / sdk