ory / sdk

The place where ORY's SDKs are being auto-generated
Apache License 2.0
141 stars 85 forks source link

Schema does not define code method for verification #260

Closed DASPRiD closed 1 year ago

DASPRiD commented 1 year ago

Preflight checklist

Describe the bug

At the time of writing (schema version 1.1.23) the schema body for updateVerificationFlowBody is set to a discriminator which only supports the link type, pointing to the updateVerificationFlowWithLinkMethod component.

There is already a updateVerificationFlowWithCodeMethodBody defined, but it is not referenced.

This causes issues for me, as I'm using an SDK client generated from a more recent OpenAPI generator version, which actually validates the input I give it against the schema. Thus I'm unable to submit any verification requests.

Reproducing the bug

  1. Generate a JavaScript SDK with the current version of OpenAPI Generator or use https://www.npmjs.com/package/@dasprid/ory-client-fetch
  2. Try to submit a verification flow with method set to code
  3. See the SDK rejecting the body.

Relevant log output

No response

Relevant configuration

selfservice:
  flows:
    recovery:
      enabled: true
      ui_url: http://localhost:4000/recovery
      use: code

Version

1.1.23

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Docker Compose

Additional Context

No response

jonas-jonas commented 1 year ago

Thanks for the report, will be fixed with https://github.com/ory/kratos/pull/3213