ory / sdk

The place where ORY's SDKs are being auto-generated
Apache License 2.0
137 stars 85 forks source link

fix: upgrade kratos typescript client to axios v1.x [security] #303

Closed LucianBuzzo closed 6 months ago

LucianBuzzo commented 8 months ago

This fixes https://nvd.nist.gov/vuln/detail/CVE-2023-45857 which is an issue discovered in Axios 0.8.1 through 1.5.1 that inadvertently reveals the confidential XSRF-TOKEN stored in cookies by including it in the HTTP header X-XSRF-TOKEN for every request made to any host allowing attackers to view sensitive information.

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

beanow-at-crabnebula commented 8 months ago

Fixes https://github.com/ory/sdk/issues/289

aeneasr commented 8 months ago

Hi - thank you for the PR. Unfortunately, this code is auto-generated and we'll need to upgrade the typescript generator. Will do that over the next couple of days!

levpachmanov commented 8 months ago

Hey @LucianBuzzo, We're part of a startup called Seal Security that mitigates software vulnerabilities in older open source versions by backporting/creating standalone security patches - enabling more straightforward remediation in cases like this. We created an axios 0.27.2-sp1 that's vulnerability-free. As with all of our patches, it's open-source and available for free.

If relevant, check out our GitHub repo if you wish to learn more, or start using our app.

Please feel free to reach us at info@seal.security if you have any requests/questions.

LucianBuzzo commented 8 months ago

@aeneasr Ok cool, Where is the source for the typescript generator?

beanow-at-crabnebula commented 8 months ago

Axios is also getting PRs for a 0.x fix such as https://github.com/axios/axios/pull/6091

aeneasr commented 6 months ago

Closing as per https://github.com/ory/sdk/pull/303#issuecomment-1812111204