ory / sdk

The place where ORY's SDKs are being auto-generated
Apache License 2.0
137 stars 85 forks source link

chore: upgrade typescript client axios to version 1.6.2 #314

Closed amirzahavi closed 6 months ago

amirzahavi commented 7 months ago

Related Issue or Design Document

305

Checklist

Further comments

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

aeneasr commented 6 months ago

Closing as per https://github.com/ory/sdk/pull/303#issuecomment-1812111204

aeneasr commented 6 months ago

Closing as per https://github.com/ory/sdk/pull/303#issuecomment-1812111204

amirzahavi commented 6 months ago

Hey @aeneasr, I understand now that the code is auto-generated, unfortunately, the linked comment states that it will be done in a couple of days (Nov 2023), but the Axios dependency is still a very old version.

Thanks 🙏🏽

Oscmage commented 6 months ago

Hey @aeneasr

To @amirzahavi point, from what I can see the client is still a two year old version of Axios(or am I missing something?):

https://github.com/ory/sdk/blob/master/clients/client/typescript/package-lock.json#L30-L31

It is difficult for us to motivate staying customers of Ory Network (which was primarily a move done for security purposes) if dependencies to client libraries are not maintained, especially when the dependencies have open security vulnerabilities.

Do you run vulnerability scanning on the SDKs that you mention on your webpage?

Oscmage commented 6 months ago

In 1.5.2 version of the client it uses a new version of axios 🎉