With Node 18 having native support for the fetch API, there is no need anymore to have a separate library for network communication.
This PR switches the typescript-axios generator out against the typescript-fetch one. If backward compatibility for older node versions is still wanted, this could instead be released as a separate package (@ory/client-fetch).
This would hugely benefit frontend projects, as users would have to download one dependency less, thus reducing loading times.
BREAKING CHANGES: This patch requires a fetch polyfill on NodeJS versions 16 and lower.
[x] I confirm that this pull request does not address a security vulnerability.
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added the necessary documentation within the code base (if appropriate).
aeneasr
commented
3 months ago
With Node 18 having native support for the fetch API, there is no need anymore to have a separate library for network communication.
This PR switches the typescript-axios generator out against the typescript-fetch one. If backward compatibility for older node versions is still wanted, this could instead be released as a separate package (@ory/client-fetch).
This would hugely benefit frontend projects, as users would have to download one dependency less, thus reducing loading times.
BREAKING CHANGES: This patch requires a fetch polyfill on NodeJS versions 16 and lower.
Further comments
https://github.com/ory/sdk/pull/256