v1.11.6 adds axios to @ory/client-fetch

xqqp commented 2 months ago

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[ ] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Ory Network Project

No response

Describe the bug

I'm using the javascript client @ory/client-fetch, which until v1.9.1 worked fine. Since the version jump to v1.11.6 axios was added to the client, as its package.json contains it as a dependency:

"dependencies": { "axios": "^1.6.1" }, The fetch client was created to not use axios in the first place. I believe this is a bug. Please review.

Reproducing the bug

Fetch @ory/client-fetch with version v1.11.6 or higher and look at the dependencies.

Relevant log output

No response

Relevant configuration

No response

Version

client version 1.11.7

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

aeneasr commented 2 months ago

Thank you for the report, that definitely seems to be a bug in the release pipeline.

richardpoole commented 3 weeks ago

This is still broken in the latest published @ory/client-fetch package: https://www.npmjs.com/package/@ory/client-fetch/v/1.11.7

ory / sdk