search

oryanm / TrelloWidget

Android widget for Trello's lists
MIT License
61 stars 24 forks source link

Architecture/redesign #42

Closed MatHazak closed 12 months ago

MatHazak commented 1 year ago

I tried to redesign the architecture by repackaging, moving some components and implementing some new components.

oryanm commented 1 year ago

This looks like a big change. Please list out what this redesign consists of, and the reasoning behind every change.

MatHazak commented 1 year ago

The main goal was to separate data-related operations from the UI layer. I implemented MVVM architecture using ViewModels. Moving the response handling (including JSON parsing) into the TrelloApi class and making requests through the repository, where we will introduce local database in the future and making the data supply consistence and clean.

I just added a description for each commit. Feel free to ask if anything is missing.

MatHazak commented 1 year ago

@oryanm Would you please make a response? I'm waiting on this. As time goes by, I have less and less time to spend on this project. I don't want to rush and do things without enough attention, but I think it's taking more time than it needs.

MatHazak commented 1 year ago

So my understanding this is just a refactor that doesn't change functionality, yes?

From a user perspective, yes, but there are actually new components with new functionality.

MatHazak commented 1 year ago

It feels like we're stuck here. I'm going to merge it into my fork and move on. I will work on #7.