search

oryanm / TrelloWidget

Android widget for Trello's lists
MIT License
61 stars 24 forks source link

Show login fragment as a dialog box #43

Open MatHazak opened 1 year ago

MatHazak commented 1 year ago

I think it would make sense to not show the widget's settings until the user logs in. The login fragment can be displayed in a dialog box, and after the user is logged in, give them access to the main screen.

oryanm commented 1 year ago

I disagree that a dialog would be an improvement in this case. If the problem is the settings we can maybe hide them while the user is logged out.

MatHazak commented 1 year ago

As a mobile user, I found this behavior a bit odd. My experience with other apps is the dialog approach. The LoginFragment doesn't grab the user's attention at first glance and is a bit confusing. From the Material Design guideline for dialogs:

A dialog is a modal window that appears in front of app content to provide critical information or ask for a decision. Dialogs disable all app functionality when they appear, and remain on screen until confirmed, dismissed, or a required action has been taken.

oryanm commented 1 year ago

The LoginFragment doesn't grab the user's attention

Again, if this is confusing we can hide the settings while the user is logged out, no? That would be a simpler solution to implement. The design guidelines are great to have but they're not laws we must follow.

MatHazak commented 12 months ago

That would be a simpler solution to implement.

Is simplicity your only concern with this change? Implementing a dialog with Material Alert Dialog Builder is simpler and more concise than the current approach. It actually reduces the code and its complexity (we no longer need to login fragment and stuff to change it).

oryanm commented 11 months ago

It's more so the UI than how much code it take to write. I just think it's cleaner to avoid a popup in this case. Sorry I was away.. there's a lot going on.

MatHazak commented 11 months ago

I just think it's cleaner to avoid a popup in this case.

As a UI POV, I gave my opinion earlier, and as I mentioned above, the Material Design guideline recommends a dialog in this case. It's not a priority at this point. We can leave this issue here until there is more participation from others.

Sorry I was away.. there's a lot going on.

No problem at all ^^ I myself am in the middle of the semester and can't devote enough time to the project.