search

orzymandias / pe

0 stars 0 forks source link

Error in the ViewMissionDeadlineCommand Sequence diagram #13

Open orzymandias opened 3 years ago

orzymandias commented 3 years ago

image.png

The static string in the ViewMissionDeadlineCommand is used to initlize the constructor.

As you can see, this is MESSAGE_SUCCESS static string from the class diagram

image.png

This is highly misleading?

nus-pe-bot commented 3 years ago

Team's Response

Could you please provide us with a more specific bug report so that we may understand how this is highly misleading?

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: Thank you for your response! My bug report about your choice to use a static string (MESSAGE_SUCCESS) for initialization which is conceptually wrong. The second image I have presented was to show that MESSAGE_SUCCESS was indeed a static string and not a method. I did not present any new information in this response so I feel that my report was sufficient to demostrate what is wrong.

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: I understand the choice to lower the severity of an issue that was unclear to you. I felt my original severity was appropriate initially as using a static string to initiate the CommandResult is highly misleading to a developer looking at the sequence diagram as one would expect a constructor being used to initialize a CommandResult but it is not make the diagram "unusable".

I feel that, in this case, medium may be appropriate as it does cause "occasional inconveience" when trying to understanding the diagram and it does appear in multiple sequence diagrams.