os-autoinst / openQA

openQA web-frontend, scheduler and tools.
http://openqa.opensuse.org/
GNU General Public License v2.0
314 stars 206 forks source link

Avoid potentially slow ws server slowing down live handler as well #5766

Closed Martchus closed 1 month ago

Martchus commented 1 month ago

After moving the code for dealing with the live view image streaming to the live handler we should avoid blocking calls in that code because the live handler is not using multiple processes.

Tested by running a test locally and observing that the live_log file in the pool directory is created/removed as expected. The unit test has also been extended to cover the error case as well.

Related ticket: https://progress.opensuse.org/issues/163757

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.44%. Comparing base (3f4dbfd) to head (b664d39).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5766 +/- ## ========================================== + Coverage 98.43% 98.44% +0.01% ========================================== Files 393 393 Lines 38615 38632 +17 ========================================== + Hits 38012 38033 +21 + Misses 603 599 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.