Allow configure-web-proxy to use a custom port

os-autoinst / openQA

openQA web-frontend, scheduler and tools.

http://openqa.opensuse.org/

GNU General Public License v2.0

314 stars 206 forks source link

Allow configure-web-proxy to use a custom port #5794

Closed kalikiana closed 1 month ago

kalikiana commented 1 month ago

Compared to the previous implementation the script code avoids test which has the side effect of changing the exit code of the entire script.

See: https://progress.opensuse.org/issues/162611

github-actions[bot] commented 1 month ago

Great PR! Please pay attention to the following items before merging:

Files matching docs/*.asciidoc:

[ ] Consider generating documentation locally to verify it is rendered correctly using tools/generate-docs

This is an automatically generated QA checklist based on modified files.

kalikiana commented 1 month ago

openqa-clone-job --skip-download --skip-chained-deps --within-instance https://openqa.opensuse.org 4360463 _GROUP=0 BUILD+=poo#4360463 OPENQA_REPO_URL=https://download.opensuse.org/repositories/devel:/openQA:/GitHub:/os-autoinst:/openQA:/PR-5794/openSUSE_Tumbleweed/
1 job has been created:                                                                                  
 - openqa-Tumbleweed-dev-x86_64-Build:TW.30156-openqa_install_multimachine@64bit-4G -> https://openqa.opensuse.org/tests/4360617

https://openqa.opensuse.org/tests/4360617

okurz commented 1 month ago

perfect, https://openqa.opensuse.org/tests/4360617#step/openqa_webui/7 shows that commit https://github.com/os-autoinst/openQA/pull/5794/commits/922de021b2ea54eda3c9ccf004bedaa8cdb6776a is installed so all good.