Make jobs running without needing to set needles URL specifically

[b10n1k]

As per https://progress.opensuse.org/issues/162632, openqa-clone-custom-git-refspec might fail in case NEEDLES_DIR is set and contains an absolute path which directs to the pool. Also in contrast of the poo's suggestion there is no change in removal of the vars.json logic.

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/tree/master https://openqa.opensuse.org/tests/4368385
1 job has been created:
 - microos-Tumbleweed-DVD-x86_64-Build20240730-fips-container-host@64bit -> https://openqa.opensuse.org/tests/4369552

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4360621  
1 job has been created:
 - openqa-Tumbleweed-dev-x86_64-Build:TW.30160-openqa_from_bootstrap@64bit-2G -> https://openqa.opensuse.org/tests/4369553

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.49%. Comparing base (fffb458) to head (ad62032). Report is 41 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #5804 +/- ## ========================================== - Coverage 98.49% 98.49% -0.01% ========================================== Files 394 394 Lines 38688 38686 -2 ========================================== - Hits 38104 38102 -2 Misses 584 584 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[b10n1k]

If this works the change would be very good. So does an invocation like

openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177 https://openqa.opensuse.org/tests/4285633 ADD_OPENQA_REPO=1

work? You should probably also try with an osado job.

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4372365 ADD_OPENQA_REPO=1 1 job has been created:

• openqa-Tumbleweed-dev-x86_64-Build:TW.30294-openqa_from_bootstrap@64bit-2G -> https://openqa.opensuse.org/tests/4372792

[b10n1k]

So you are removing all mentions of setting the needles dir from the test and the script but then we should have actual verification that you are not breaking existing use cases.

Which are?

[Martchus]

If this works the change would be very good. So does an invocation like

openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177 https://openqa.opensuse.org/tests/4285633 ADD_OPENQA_REPO=1

work? You should probably also try with an osado job.

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4372365 ADD_OPENQA_REPO=1 1 job has been created:

* openqa-Tumbleweed-dev-x86_64-Build:TW.30294-openqa_from_bootstrap@64bit-2G -> https://openqa.opensuse.org/tests/4372792

This looks good. Now try with an osado job to cover the case when NEEDLES_DIR is present in the job to be cloned.

[b10n1k]

If this works the change would be very good. So does an invocation like

openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177 https://openqa.opensuse.org/tests/4285633 ADD_OPENQA_REPO=1

work? You should probably also try with an osado job.

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4372365 ADD_OPENQA_REPO=1 1 job has been created:

* openqa-Tumbleweed-dev-x86_64-Build:TW.30294-openqa_from_bootstrap@64bit-2G -> https://openqa.opensuse.org/tests/4372792

This looks good. Now try with an osado job to cover the case when NEEDLES_DIR is present in the job to be cloned.

❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/tree/master https://openqa.opensuse.org/tests/4368385 ADD_OPENQA_REPO=1 1 job has been created:

• microos-Tumbleweed-DVD-x86_64-Build20240730-fips-container-host@64bit -> https://openqa.opensuse.org/tests/4376034

[Martchus]

Ok, looks like all common cases just continue to work.