Closed b10n1k closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.49%. Comparing base (
fffb458
) to head (ad62032
). Report is 41 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If this works the change would be very good. So does an invocation like
openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177 https://openqa.opensuse.org/tests/4285633 ADD_OPENQA_REPO=1
work? You should probably also try with an osado job.
❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4372365 ADD_OPENQA_REPO=1 1 job has been created:
So you are removing all mentions of setting the needles dir from the test and the script but then we should have actual verification that you are not breaking existing use cases.
Which are?
If this works the change would be very good. So does an invocation like
openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177 https://openqa.opensuse.org/tests/4285633 ADD_OPENQA_REPO=1
work? You should probably also try with an osado job.
❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4372365 ADD_OPENQA_REPO=1 1 job has been created:
* openqa-Tumbleweed-dev-x86_64-Build:TW.30294-openqa_from_bootstrap@64bit-2G -> https://openqa.opensuse.org/tests/4372792
This looks good. Now try with an osado job to cover the case when NEEDLES_DIR
is present in the job to be cloned.
If this works the change would be very good. So does an invocation like
openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177 https://openqa.opensuse.org/tests/4285633 ADD_OPENQA_REPO=1
work? You should probably also try with an osado job.
❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4372365 ADD_OPENQA_REPO=1 1 job has been created:
* openqa-Tumbleweed-dev-x86_64-Build:TW.30294-openqa_from_bootstrap@64bit-2G -> https://openqa.opensuse.org/tests/4372792
This looks good. Now try with an osado job to cover the case when
NEEDLES_DIR
is present in the job to be cloned.
❯ script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/tree/master https://openqa.opensuse.org/tests/4368385 ADD_OPENQA_REPO=1 1 job has been created:
Ok, looks like all common cases just continue to work.
As per https://progress.opensuse.org/issues/162632, openqa-clone-custom-git-refspec might fail in case NEEDLES_DIR is set and contains an absolute path which directs to the pool. Also in contrast of the poo's suggestion there is no change in removal of the vars.json logic.