codecov[bot]
commented
1 month ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.49%. Comparing base (
fffb458) to head (294d4b7).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #5806 +/- ## ========================================== - Coverage 98.49% 98.49% -0.01% ========================================== Files 394 394 Lines 38688 38686 -2 ========================================== - Hits 38104 38102 -2 Misses 584 584 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In efe1cdef6 next to "USER_CANCELLED" also "OBSOLETED" jobs were added to the list where to skip a "RETRY" which was the safe choice. I think we should treat all "aborted results" the same which means now additionally including SKIPPED, PARALLEL_FAILED, PARALLEL_RESTARTED, USER_RESTARTED.
As @baierjan explained in https://github.com/os-autoinst/openQA/pull/5797/files#r1697036344 "restarting jobs which were already restarted (USER_RESTARTED, PARALLEL_RESTARTED) probably does not make much sense, which leaves PARALLEL_FAILED and SKIPPED. I guess PARALLEL_FAILED would be restarted anyway if needed by the parallel job?" The later question can be answered with yes so we should be good. And "SKIPPED" means "(directly) chained dependencies failed before starting this job" so I also don't see a need to try a RETRY on those.
Related progress issue: https://progress.opensuse.org/issues/164613