os-autoinst / openQA

openQA web-frontend, scheduler and tools.
http://openqa.opensuse.org/
GNU General Public License v2.0
314 stars 206 forks source link

Fix sporadic failures in test of candidates menu #5809

Closed Martchus closed 1 month ago

Martchus commented 1 month ago

wait_for_ajax_and_animations does not fully cover the asynchronous behaviors of the code and also doesn't help with animations. (The relevant animation is already globally disabled via $.fx.off = true; but this does not mean code becomes synchronous.)

With this change we simply wait for the element to show up instead.

Related ticket: https://progress.opensuse.org/issues/164745

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.49%. Comparing base (f7f8498) to head (f0e94ef).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5809 +/- ## ========================================== - Coverage 98.49% 98.49% -0.01% ========================================== Files 394 394 Lines 38686 38685 -1 ========================================== - Hits 38102 38101 -1 Misses 584 584 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.