search

os-autoinst / openQA

openQA web-frontend, scheduler and tools.
http://openqa.opensuse.org/
GNU General Public License v2.0
316 stars 205 forks source link

Add interactive log viewer #5836

Closed perlpunk closed 1 month ago

perlpunk commented 1 month ago

One can now filter the log files for substring and regexes.

Demo: https://github.com/user-attachments/assets/f6dec605-951a-4e14-8f93-18acd461a708

Issue: https://progress.opensuse.org/issues/162218

okurz commented 1 month ago

s/Conecpt/Concept/

perlpunk commented 1 month ago

@asmorodskyi WDYT?

perlpunk commented 1 month ago

I'm not sure what the linter is trying to tell me:

/home/runner/work/openQA/openQA/assets/javascripts/test_result.js
Error:   627:47  error  Insert `·`  prettier/prettier

ah, got it. space before ()

asmorodskyi commented 1 month ago

@asmorodskyi WDYT?

Thanks for demo ! LGTM ! This is certainly step in right direction !

perlpunk commented 1 month ago

The feature seems to work like I want it now. Feel free to try it out. It will add the current search to the url, so you can bookmark it. I want to modify how it gets added to the url though.

And I still need to write a test.

okurz commented 1 month ago

Need to tidy

perlpunk commented 1 month ago

I added the test and other small fixes. Reviews welcome

perlpunk commented 1 month ago

Updated style suggestions

perlpunk commented 1 month ago

https://app.circleci.com/pipelines/github/os-autoinst/openQA/14310/workflows/f3cd9c56-a41b-4d72-af6e-179dd73ac79b/jobs/135289

[19:35:02] t/ui/18-tests-details.t .................... 13/? 
    #   Failed test 'Showing filter result info for substring'
    #   at t/ui/18-tests-details.t line 489.
Wide character in print at /usr/lib/perl5/5.26.1/Test2/Formatter/TAP.pm line 105.
    #                   'Searching…'
    #     doesn't match '(?^:Showing 3 / 1292 lines)'

    #   Failed test 'qemu-kvm is not shown when filtering for something else'
    #   at t/ui/18-tests-details.t line 491.
    #                   '1392725754
    # 2014-02-18 12:15:54

I needed to take back some of the style suggestion changes.

edit: fixed

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.50%. Comparing base (b24c267) to head (5313e25). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5836 +/- ## ======================================= Coverage 98.50% 98.50% ======================================= Files 395 395 Lines 38759 38767 +8 ======================================= + Hits 38180 38188 +8 Misses 579 579 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.