search

os-autoinst / openQA

openQA web-frontend, scheduler and tools.
http://openqa.opensuse.org/
GNU General Public License v2.0
321 stars 208 forks source link

Fix firewall configuration in Autoyast profile #5839

Closed b10n1k closed 2 months ago

b10n1k commented 2 months ago

Configure the firewall properties as SuSEfirewall2 has been replaced by firewalld and the validation produce a warning. FW_CONFIGURATIONS_EXT keeps working so far because is supported but it is deprecated.

https://progress.opensuse.org/issues/156169

b10n1k commented 2 months ago

Can you clarify how you tested that? As we don't have automatic tests for autoyast yet that matters :)

with yast autoyast check-profile. I didnt try to perform an installation in some VM.

okurz commented 2 months ago

Can you clarify how you tested that? As we don't have automatic tests for autoyast yet that matters :)

with yast autoyast check-profile. I didnt try to perform an installation in some VM.

hm, I don't know if yast autoyast check-profile is depending on the OS version on which it's called or if it can be trusted to not produce false positives so please verify with an actual installation if this works as expected.

Martchus commented 2 months ago

The commit message is not very easy to read and contains a few grammar mistakes. This is also technically not fixing anything at this point. What about:

Avoid using deprecated Autoyast config for firewall

* Avoid deprecation warning about using firewall property
  from SuSEfirewall2 times
* Use firewalld configuration instead

Related ticket: https://progress.opensuse.org/issues/156169

And yes, it would make sense to test this, e.g. by installing it in a VM.

b10n1k commented 2 months ago

Avoid using deprecated Autoyast config for firewall

  • Avoid deprecation warning about using firewall property from SuSEfirewall2 times
  • Use firewalld configuration instead

Updated on 287f0cd31