os-autoinst / openQA

openQA web-frontend, scheduler and tools.
http://openqa.opensuse.org/
GNU General Public License v2.0
321 stars 208 forks source link

Use perlcritic wrapper and plugins from common repo #5843

Closed perlpunk closed 2 months ago

perlpunk commented 2 months ago

Also create a github workflow for it.

Issue: https://progress.opensuse.org/issues/155188

github-actions[bot] commented 2 months ago

Great PR! Please pay attention to the following items before merging:

Files matching external/**:

This is an automatically generated QA checklist based on modified files.

perlpunk commented 2 months ago

Ok, while trying to fix more perlcritic complaints I found out that the plugins actually need more fixes. I wish those plugins had been tested on our code base before.

perlpunk commented 2 months ago

After

perlpunk commented 2 months ago

https://app.circleci.com/pipelines/github/perlpunk/openQA/357/workflows/d8ac13a9-ce17-413a-bbc2-8b9779b9e1a2/jobs/2482

[13:16:03] t/05-scheduler-full.t .. 1/? 
    #   Failed test 'jobs dispatched to different workers'
    #   at t/05-scheduler-full.t line 119.
    #          got: undef
    #     expected: anything else

    #   Failed test 'each of the two jobs allocated to one of the workers'
    #   at t/05-scheduler-full.t line 120.
    #          got: undef
    #     expected: anything else
    # 0
    # Looks like you failed 2 tests of 4.
[13:16:03] t/05-scheduler-full.t .. 2/? 
#   Failed test 'Scheduler worker job allocation'
#   at t/05-scheduler-full.t line 128.
...

This seems unrelated. I'll retrigger

perlpunk commented 2 months ago

Created https://progress.opensuse.org/issues/165198 for the unrelated failing test

perlpunk commented 2 months ago

So there seems to be a problem with circleci - I retriggered the failing test and it passed now, but the links in the github checks still link to the older run. Also the codecov upload failed with the typical token error. Let's see what happens when I rebase to trigger a completely new run